Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751195Ab1EPFQ4 (ORCPT ); Mon, 16 May 2011 01:16:56 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:52561 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876Ab1EPFQz (ORCPT ); Mon, 16 May 2011 01:16:55 -0400 Message-ID: <78EB813416554F1A973EF20AA714ADF8@subhasishg> From: "Subhasish Ghosh" To: "Nori, Sekhar" Cc: "Greg KH" , , , "Watkins, Melissa" , , "Andrew Morton" , "Randy Dunlap" , "open list" Subject: Re: [PATCH v4 08/11] tty: add pruss SUART driver Date: Mon, 16 May 2011 10:47:18 +0530 Organization: Mistral Solutions MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal Importance: Normal X-Mailer: Microsoft Windows Live Mail 14.0.8117.416 X-MimeOLE: Produced By Microsoft MimeOLE V14.0.8117.416 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 30 Hi Sekhar, >>> Say, if the driver is loaded as a module. >>> If I allocate the sram in the platform code, how to I >>> free it when the driver is unloaded. >> >> This is what I said in my last e-mail. What is >> the issue you see with this approach? >> >> | Thanks for the clarification. In this case, the driver >> | should use platform callbacks to get/put fast fifo >> | space. In case this callback is not populated by the >> | platform or returns an error, the driver should fall >> | back to allocating from DDR. >> > > ok, so what you are suggesting is that I implement some > callbacks (like .fifo_alloc, .fifo_dealloc) which can allocate > memory using sram_alloc. > My doubt is, if already such API's are there (by Russel) or you > are suggesting to implement them. I can add the fifo_alloc/dealloc as part of the suart platform_data, Is that's what you are suggesting. If you may please point me out to any example. I am just not clear with this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/