Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751468Ab1EPF4T (ORCPT ); Mon, 16 May 2011 01:56:19 -0400 Received: from cantor.suse.de ([195.135.220.2]:37907 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043Ab1EPF4R (ORCPT ); Mon, 16 May 2011 01:56:17 -0400 Message-ID: <4DD0BC7E.3060901@suse.de> Date: Mon, 16 May 2011 07:56:14 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8 MIME-Version: 1.0 To: Oliver Neukum Cc: James Bottomley , "Rafael J. Wysocki" , Charles Hannum , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Alan Stern , linux-scsi , linux-usb@vger.kernel.org Subject: Re: [PATCH] scsi/sd: fix suspend with USB-connected Android phone (one line) References: <201105122203.13671.rjw@sisk.pl> <1305232563.2575.85.camel@mulgrave.site> <201105142111.53266.oliver@neukum.org> In-Reply-To: <201105142111.53266.oliver@neukum.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2034 Lines: 55 On 05/14/2011 09:11 PM, Oliver Neukum wrote: > Am Donnerstag, 12. Mai 2011, 22:36:03 schrieb James Bottomley: > >> Instinct tells me the correct set of fixes is to add a sync cache from >> release (so we automatically sync on last close, which is usually when >> an ordered remove happens), keep the one on shutdown, just in case the >> system goes down with stuff still mounted and print a nasty message on >> suspend for a write back device that's been removed. >> >> I also think we shouldn't abort the suspend if the disk doesn't respond >> correctly to start/stop ... the power is going to be disconnected >> anyway, so it's no issue if the disk spins for a second or so longer. >> >> The problem this is going to cause is double sync on shutdown (once when >> final unmount closes the device and once on shutdown) ... do people >> agree that's a price worth paying? >> >> Something like this? > > Hi, > > it seems to me that the error codes should really be evaluated a bit better. > How about this? > > Regards > Oliver > > From 2ab03ae46d6dc126a51ee9cd38206fbdc8bf6a34 Mon Sep 17 00:00:00 2001 > From: Oliver Neukum > Date: Mon, 25 Oct 2010 12:25:26 +0200 > Subject: [PATCH 2/5] SCSI:sd:error handling in sd_sync_cache() > > The SCSI commands sd_sync_cache() uses may fail. > These errors needs to be evaluated to return correct > error codes. This fixes system suspension while a device > removal is being handled. > > Signed-off-by: Oliver NEukum Yep, this makes sense. Acked-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/