Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754756Ab1EPLCz (ORCPT ); Mon, 16 May 2011 07:02:55 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:53187 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754400Ab1EPLCy (ORCPT ); Mon, 16 May 2011 07:02:54 -0400 X-AuditID: cbfee610-b7ce1ae000005168-5e-4dd1045d28db Date: Mon, 16 May 2011 11:02:53 +0000 (GMT) From: MyungJoo Ham Subject: Re: [PATCH RESEND] regulator: Remove MAX8997_REG_BUCK1DVS/MAX8997_REG_BUCK2DVS/MAX8997_REG_BUCK5DVS macros To: Axel Lin , "linux-kernel@vger.kernel.org" Cc: =?euc-kr?Q?=B9=DA=B0=E6=B9=CE?= , Liam Girdwood , Mark Brown , Samuel Ortiz Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20110516110038178@myungjoo.ham Msgkey: 20110516110038178@myungjoo.ham X-EPLocale: ko_KR.euc-kr X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-EPTrCode: X-EPTrName: X-MLAttribute: X-RootMTR: 20110516110038178@myungjoo.ham X-ParentMTR: Content-type: text/plain; charset=euc-kr MIME-version: 1.0 Message-id: <174186.97941305543772726.JavaMail.weblogic@epml26> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id p4GB30dA024079 Content-Length: 1049 Lines: 24 > Sender : Axel Lin > Date : 2011-05-16 19:20 (GMT+09:00) > Title : [PATCH RESEND] regulator: Remove MAX8997_REG_BUCK1DVS/MAX8997_REG_BUCK2DVS/MAX8997_REG_BUCK5DVS macros > > In current implementation, the original macro implementation assumes the caller > pass the parameter starting from 1 (to match the register names in datasheet). > Thus we have unneeded plus one then minus one operations > when using MAX8997_REG_BUCK1DVS/MAX8997_REG_BUCK2DVS/MAX8997_REG_BUCK5DVS macros. > > This patch removes these macros to avoid unneeded plus one then minus one operations > without reducing readability. > > Signed-off-by: Axel Lin It looks good. Thanks! Acked-by: MyungJoo Ham MyungJoo Ham Mobile Software Platform Lab, Digital Media and Communications (DMC) Business Samsung Electronics cell: +82-10-6714-2858 / office: +82-31-279-8033????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?