Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490Ab1EPLe1 (ORCPT ); Mon, 16 May 2011 07:34:27 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:39163 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751459Ab1EPLe0 (ORCPT ); Mon, 16 May 2011 07:34:26 -0400 Date: Mon, 16 May 2011 13:34:11 +0200 From: Ingo Molnar To: Suresh Siddha Cc: Daniel J Blueman , Thomas Gleixner , Ingo Molnar , H Peter Anvin , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ioapic: fix potential resume deadlock Message-ID: <20110516113411.GG19837@elte.hu> References: <1304908814-23369-1-git-send-email-daniel.blueman@gmail.com> <20110510073551.GH11595@elte.hu> <1305071894.2736.50.camel@sbsiddha-MOBL3.sc.intel.com> <1305308919.27535.19.camel@sbsiddha-MOBL3.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1305308919.27535.19.camel@sbsiddha-MOBL3.sc.intel.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1709 Lines: 42 * Suresh Siddha wrote: > On Wed, 2011-05-11 at 09:15 -0700, Daniel J Blueman wrote: > > Superb, this works, tested against 2.6.39-rc7 and addresses the "BUG: > > sleeping function called from invalid context at mm/slub.c:824" > > warning I was previously seeing. It would be good to get this fix into > > 2.6.39-final if possible. > > > > Tested-by: Daniel J Blueman > > Thanks Daniel for testing my quick patch. I have appended the complete > patch which cleans up this code. > > Ingo, This patch is relatively big (mostly removes the duplicate code > and changes the location where we allocate ioapic_saved_data, so that > this can be shared between interrupt-remapping and io-apic > suspend/resume flows). May be this can go into 2.6.40-rc1 and probably > go to 2.6.39-stable? Could you please split it up into multiple steps? Commits with such a diffstat: > arch/x86/include/asm/io_apic.h | 21 ++---- > arch/x86/kernel/apic/apic.c | 49 ++++---------- > arch/x86/kernel/apic/io_apic.c | 148 +++++++++++----------------------------- > 3 files changed, 61 insertions(+), 157 deletions(-) ... rarely come without regressions attached, and it's a whole lot easier to figure out what's wrong with a small patch out of 3-4 than with such a big patch. I'd suggest to make the end result exactly the same as this one big patch, so that we preserve Daniel's testing results. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/