Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755654Ab1EPOoP (ORCPT ); Mon, 16 May 2011 10:44:15 -0400 Received: from www.linutronix.de ([62.245.132.108]:46505 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755305Ab1EPOoO (ORCPT ); Mon, 16 May 2011 10:44:14 -0400 Date: Mon, 16 May 2011 16:44:06 +0200 (CEST) From: Thomas Gleixner To: Santosh Shilimkar cc: Colin Cross , Linus Walleij , Russell King , Srinidhi KASAGAR , Harald Gustafsson , Linus Walleij , linux-kernel@vger.kernel.org, Rickard ANDERSSON , martin persson , Varun Swara , Catalin Marinas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: twd: Adjust localtimer frequency withcpufreqnotifiers In-Reply-To: <4DD10814.1010103@ti.com> Message-ID: References: <1290060899-9786-1-git-send-email-ccross@android.com> <4D70BE9D.4000507@stericsson.com> <4D714C17.7080102@gmail.com> <7e9fafa016bfe536ccc373fc2cc7ba61@mail.gmail.com> <4DD10814.1010103@ti.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1139 Lines: 31 On Mon, 16 May 2011, Santosh Shilimkar wrote: > On 5/14/2011 9:21 PM, Thomas Gleixner wrote: > Just for my understanding, the clockevents_reconfigure() needs to > be called with interrupts disabled on that CPU as part of > the CPUFREQ notifiers. I assume the right place is do it > in POST notifier after the CPU clock and hence TWD clock is > updated. Is that right ? Yes. > Since there is need to call this API in interrupt > disable context, does it make sense to take care of it > inside the API itself instead of relying on caller fn ? Hmm, no strong opinion > The arch's where the per CPU TWD's share clock, per-cpu > clock-events should be reconfigured on all CPUs, whenever > the parent(CPU) clock has changed using some thing like > smp_call_function_any() etc. Is that right understanding? Yes. If that's a common requirement we should move that to core code. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/