MIME-version: 1.0
Content-transfer-encoding: 7BIT
Content-type: TEXT/PLAIN; charset=US-ASCII
Date: Mon, 16 May 2011 16:31:49 -0400 (EDT)
From: Nicolas Pitre <nico@fluxnic.net>
To: Andrew Lunn <andrew@lunn.ch>
Cc: kernel@wantstofly.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, saeed.bishara@gmail.com
Subject: Re: [PATCHv2 00/15] Consolidate Orion platform information setup.
In-reply-to: <1305459174-25517-1-git-send-email-andrew@lunn.ch>
Message-id: <alpine.LFD.2.00.1105161608340.14430@xanadu.home>
References: <1305459174-25517-1-git-send-email-andrew@lunn.ch>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1474
Lines: 36

On Sun, 15 May 2011, Andrew Lunn wrote:

> This patchset consolidates some of the code used for creating
> platform data for various orion based SoC, namely Dove, Loki, Kirkwood,
> mv78xx0 and Orion5x. Where possible, this code has been put into the
> orion platform, with the mach-*/common.c calling the common platform
> code.
> 
> Additionally the setup of the multi purpose pins has been consolidated.
> Kirkwood and mv78xx0 had identical code, which has been generalized and
> put into the platform. Orion5x and Dove mpp code has been re-written to 
> use the consolidated method.
> 
> Tested on a Kirkwood device, otherwise compile tested.
> 
> Changes since last version:
> 
>  - Typos found by Saeed Bishara fixed
>  - All ethernets reserve the same size
>  - Add Kirkwood RTC interrupt as a seperate patch
>  - Rather than drop the dove mpp code, refactor to use the platform code.

This looks great. Thanks for this work. That will certainly make any 
transition to device tree much simpler.

Some further consolidation could be achieved by dynamically allocating 
the platform device structures as needed and having a single function 
for each class of devices.  But that can be done in a subsequent series.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/