DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:content-type:to:cc:subject:references:date:mime-version
         :content-transfer-encoding:from:message-id:in-reply-to:user-agent;
        b=P7RHhe+zl8cWsUk7S7v+zxeIdJqav4B7kuvNiYUUo6otja19CTOcwbjAa/1QQhsycU
         nF8eQZP5NSPT/y+35brXus9sRc0/wJsPWyZ2SGFOD97XqvQFst6hcQvj2XN3c3rPZ5QK
         eh7dxUvtfmxcv905Hxze97fdeU+zO1lihfzh4=
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: "David Rientjes" <rientjes@google.com>,
        "Andy Whitcroft" <apw@canonical.com>, "Joe Perches" <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        "John Stultz" <john.stultz@linaro.org>, "Ted Ts'o" <tytso@mit.edu>,
        "Jiri Slaby" <jirislaby@gmail.com>,
        "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>,
        "Dave Hansen" <dave@linux.vnet.ibm.com>,
        "Andrew Morton" <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH 3/3] checkpatch.pl: Add check for task comm references
References: <1305580757-13175-1-git-send-email-john.stultz@linaro.org>
 <1305580757-13175-4-git-send-email-john.stultz@linaro.org>
 <op.vvlfaobx3l0zgt@mnazarewicz-glaptop>
 <alpine.DEB.2.00.1105161431550.4353@chino.kir.corp.google.com>
 <1305587090.2503.42.camel@Joe-Laptop>
Date: Tue, 17 May 2011 01:11:45 +0200
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: "Michal Nazarewicz" <mina86@mina86.com>
Message-ID: <op.vvlj1vad3l0zgt@mnazarewicz-glaptop>
In-Reply-To: <1305587090.2503.42.camel@Joe-Laptop>
User-Agent: Opera Mail/11.10 (Linux)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1073
Lines: 26

On Tue, 17 May 2011 01:04:50 +0200, Joe Perches <joe@perches.com> wrote:

> On Mon, 2011-05-16 at 14:34 -0700, David Rientjes wrote:
>> On Mon, 16 May 2011, Michal Nazarewicz wrote:
>> > > Now that accessing current->comm needs to be protected,
>> > > +# check for current->comm usage
>> > > +		if ($line =~ /\b(?:current|task|tsk|t)\s*->\s*comm\b/) {
>> > Not a checkpatch.pl expert but as far as I'm concerned, that looks  
>> reasonable.
>
> I think the only checkpatch expert is Andy Whitcroft.
>
> You don't need (?: just (

Yep, it's a micro-optimisation though.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@google.com>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/