Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755476Ab1EQOxZ (ORCPT ); Tue, 17 May 2011 10:53:25 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:47378 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755225Ab1EQOxY (ORCPT ); Tue, 17 May 2011 10:53:24 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Q3zVru9KABuGTMXSUx6FalUDVtzgp92Awxoyc3GxLhrrIQKDbVWmoGR0VJ1tvLM62b /7wEdCxHfKzBlXXZzClphHAhMGsL20jXEiTMazOyAHj6joZ9euO4bYCY/77X71XXcmFU VMD0PUGxFJ3T9DDFgPB7mct8VhD70UrO37dd4= MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 17 May 2011 22:53:22 +0800 Message-ID: Subject: Re: [PATCH] sched: fix priority leakage in pick_next_highest_task_rt() From: Hillf Danton To: Yong Zhang Cc: LKML , Ingo Molnar , Peter Zijlstra , Mike Galbraith Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 940 Lines: 23 On Tue, May 17, 2011 at 10:28 AM, Yong Zhang wrote: > On Mon, May 16, 2011 at 8:55 PM, Hillf Danton wrote: >> When picking the second highest RT task for a given runqueue, if no >> task found after scanning the queue of priority == idx, the next idx >> should also be checked even in case that next is already existing, or >> the window of priority leakage could be opened. > > I don't see what kind of problem you patch will fix. > And mind explaining how priority leakage could happen? > Hi Yong If no task is found after scanning the list at array->queue + idx, what should we operate on next? And why is the list scanned? thanks Hillf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/