Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756261Ab1EQSai (ORCPT ); Tue, 17 May 2011 14:30:38 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:40477 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756067Ab1EQSah (ORCPT ); Tue, 17 May 2011 14:30:37 -0400 Date: Tue, 17 May 2011 19:30:15 +0100 From: Russell King To: Greg KH Cc: Shreshtha Kumar SAHU , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@stericsson.com, alan@linux.intel.com Subject: Re: [PATCHv2 1/2] amba pl011: workaround for uart registers lockup Message-ID: <20110517183015.GA15422@flint.arm.linux.org.uk> References: <20110516172958.GA13011@kroah.com> <1305609617-9524-1-git-send-email-shreshthakumar.sahu@stericsson.com> <20110517182356.GA17703@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110517182356.GA17703@kroah.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 506 Lines: 14 On Tue, May 17, 2011 at 11:23:56AM -0700, Greg KH wrote: > Why? You don't use these callbacks in this driver, so why add them? Did you look at the second patch? -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/