Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932635Ab1EQXYP (ORCPT ); Tue, 17 May 2011 19:24:15 -0400 Received: from out4.smtp.messagingengine.com ([66.111.4.28]:36710 "EHLO out4.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932561Ab1EQXYO (ORCPT ); Tue, 17 May 2011 19:24:14 -0400 X-Sasl-enc: DlslRhlgMmGEtdoJp8IdkdzBXnRGqHAPouMQxtHi8LL/ 1305674653 Date: Tue, 17 May 2011 16:22:41 -0700 From: Greg KH To: Alessio Igor Bogani Cc: Rusty Russell , Anders Kaseorg , Tim Abbott , Tim Bird , LKML , Linux Embedded , Jason Wessel , Dirk Behme Subject: Re: [PATCH] module: Use binary search in lookup_symbol() Message-ID: <20110517232241.GA19140@kroah.com> References: <1305665763-3988-1-git-send-email-abogani@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1305665763-3988-1-git-send-email-abogani@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 653 Lines: 19 On Tue, May 17, 2011 at 10:56:03PM +0200, Alessio Igor Bogani wrote: > This work was supported by a hardware donation from the CE Linux Forum. > > Signed-off-by: Alessio Igor Bogani > --- That's nice, but _why_ do this change? What does it buy us? Please explain why you make a change, not just who sponsored the change, that's not very interesting to developers. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/