Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932417Ab1ERACx (ORCPT ); Tue, 17 May 2011 20:02:53 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:49101 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932303Ab1ERACw (ORCPT ); Tue, 17 May 2011 20:02:52 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Message-ID: <4DD30C9E.8010200@jp.fujitsu.com> Date: Wed, 18 May 2011 09:02:38 +0900 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: wilsons@start.ca CC: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, hughd@google.com, rientjes@google.com, lee.schermerhorn@hp.com, adobriyan@gmail.com, cl@linux-foundation.org Subject: Re: [PATCH v2 7/9] mm: proc: move show_numa_map() to fs/proc/task_mmu.c References: <1305498029-11677-1-git-send-email-wilsons@start.ca> <1305498029-11677-8-git-send-email-wilsons@start.ca> In-Reply-To: <1305498029-11677-8-git-send-email-wilsons@start.ca> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 32 (2011/05/16 7:20), Stephen Wilson wrote: > Moving show_numa_map() from mempolicy.c to task_mmu.c solves several > issues. > > - Having the show() operation "miles away" from the corresponding > seq_file iteration operations is a maintenance burden. > > - The need to export ad hoc info like struct proc_maps_private is > eliminated. > > - The implementation of show_numa_map() can be improved in a simple > manner by cooperating with the other seq_file operations (start, > stop, etc) -- something that would be messy to do without this > change. > > Signed-off-by: Stephen Wilson > Cc: KOSAKI Motohiro > Cc: Hugh Dickins > Cc: David Rientjes > Cc: Lee Schermerhorn > Cc: Alexey Dobriyan > Cc: Christoph Lameter Reviewed-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/