Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756684Ab1ERXfw (ORCPT ); Wed, 18 May 2011 19:35:52 -0400 Received: from ozlabs.org ([203.10.76.45]:48903 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756170Ab1ERXfu (ORCPT ); Wed, 18 May 2011 19:35:50 -0400 From: Rusty Russell To: Dirk Behme Cc: Alessio Igor Bogani , Anders Kaseorg , Tim Abbott , Tim Bird , LKML , Linux Embedded , Jason Wessel Subject: Re: [PATCH] module: Use binary search in lookup_symbol() In-Reply-To: <4DD2CA02.9040707@googlemail.com> References: <1305577420-3685-1-git-send-email-abogani@kernel.org> <878vu6nftw.fsf@rustcorp.com.au> <4DD2CA02.9040707@googlemail.com> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1 (i686-pc-linux-gnu) Date: Wed, 18 May 2011 10:40:15 +0930 Message-ID: <87ipt8n79k.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1641 Lines: 48 On Tue, 17 May 2011 21:18:26 +0200, Dirk Behme wrote: > On 17.05.2011 05:52, Rusty Russell wrote: > > On Mon, 16 May 2011 22:23:40 +0200, Alessio Igor Bogani wrote: > >> This work was supported by a hardware donation from the CE Linux Forum. > >> > >> Signed-off-by: Alessio Igor Bogani > >> --- > >> kernel/module.c | 6 ++---- > >> 1 files changed, 2 insertions(+), 4 deletions(-) > >> > >> diff --git a/kernel/module.c b/kernel/module.c > >> index 6a34337..54355c5 100644 > >> --- a/kernel/module.c > >> +++ b/kernel/module.c > >> @@ -2055,10 +2055,8 @@ static const struct kernel_symbol *lookup_symbol(const char *name, > >> const struct kernel_symbol *stop) > >> { > >> const struct kernel_symbol *ks = start; > >> - for (; ks< stop; ks++) > >> - if (strcmp(ks->name, name) == 0) > >> - return ks; > >> - return NULL; > >> + return bsearch(name, start, stop - start, > >> + sizeof(struct kernel_symbol), cmp_name); > >> } > >> > >> static int is_exported(const char *name, unsigned long value, > > > > Applied. > > Sorry, but where have you applied it? The -rr tree which goes to linux-next. > With the version above we should get a warning > > kernel/module.c: In function 'lookup_symbol': > kernel/module.c:1809: warning: unused variable 'ks' Yep, fixed that up too, thanks. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/