Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944Ab1ERF5B (ORCPT ); Wed, 18 May 2011 01:57:01 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:38876 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752592Ab1ERF5A convert rfc822-to-8bit (ORCPT ); Wed, 18 May 2011 01:57:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=SfX/v8pdZe7CorlVbXlk38wIzW1YUoUBtIQvCJMcM7c7oEeNzU8B8OCTwO17Xp5iFd PpHeFryOmtdEJyCXMzOO3H/ixbMCmb9d+3jwNZ+tBAyeRJlNZdvo1oj3fMnxQNwr0sSN hg/hrbIMnYm26VE9jr+ou1jPP9NtGiWAYziAI= MIME-Version: 1.0 In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF0498A478E6@HQMAIL01.nvidia.com> References: <1305070783-23193-1-git-send-email-linus.walleij@linaro.org> <74CDBE0F657A3D45AFBB94109FB122FF0498A478E6@HQMAIL01.nvidia.com> Date: Wed, 18 May 2011 07:56:59 +0200 X-Google-Sender-Auth: zSI1Sx1pBskY0QzDNpLZvRCAQTs Message-ID: Subject: Re: [PATCH] drivers: create a pinmux subsystem v2 From: Linus Walleij To: Stephen Warren Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Martin Persson , Joe Perches , Lee Jones , Russell King Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2851 Lines: 96 2011/5/18 Stephen Warren : >> +static struct foo_pmx_func myfuncs[] = { >> + ? ? { >> + ? ? ? ? ? ? .name = "spi0-0", >> + ? ? ? ? ? ? .pins = spi0_0_pins, >> + ? ? ? ? ? ? .num_pins = ARRAY_SIZE(spi0_1_pins), >> + ? ? }, >> + ? ? { >> + ? ? ? ? ? ? .name = "i2c0", >> + ? ? ? ? ? ? .pins = i2c0_pins, >> + ? ? ? ? ? ? .num_pins = ARRAY_SIZE(i2c0_pins), >> + ? ? }, >> + ? ? { >> + ? ? ? ? ? ? .name = "spi0-1", >> + ? ? ? ? ? ? .pins = spi0_1_pins, >> + ? ? ? ? ? ? .num_pins = ARRAY_SIZE(spi0_1_pins), >> + ? ? }, >> +}; > > Rather than defining a custom type (foo_pmx_func) for this array inside > each driver, and then having to implement _list, _get_fname, _get_pins > below, how about: > > * pinmux core defines a basic structure containing all the information > ?that the core needs from the specific implementation. > > * This structure would need a field to point at the implementation- > ?specific data. > > * We could get rid of _list, _get_fname, _get_pins completely from > ?pinmux_ops. > > pinmux.h: > > struct pinmux_function { > ? ? ? ?char *name; > ? ? ? ?const unsigned int *pins; > ? ? ? ?const unsigned num_pins; > ? ? ?void *driver_data; > }; > > driver source: > > struct foo_pmx_func { > ? ? ? ?int register; > ? ? ? ?int mask; > ? ? ? ?int value; > }; > > static struct foo_pmx_func spi0_0_func = { > ? ? ? ?FOO_REG_PMX_A, > ? ? ? ?0x30, > ? ? ? ?0x10, > }; > ... > static struct pinmux_function myfuncs[] = { > ? ? ? ?{ > ? ? ? ? ? ? ? ?.name = "spi0-0", > ? ? ? ? ? ? ? ?.pins = spi0_0_pins, > ? ? ? ? ? ? ? ?.num_pins = ARRAY_SIZE(spi0_1_pins), > ? ? ? ? ? ? ? ?.driver_data = &spi0_0_func, > ? ? ? ?}, > ? ? ? ?{ > ? ? ? ? ? ? ? ?.name = "i2c0", > ? ? ? ? ? ? ? ?.pins = i2c0_pins, > ? ? ? ? ? ? ? ?.num_pins = ARRAY_SIZE(i2c0_pins), > ? ? ? ? ? ? ? ?.driver_data = &i2c0_func, > ? ? ? ?}, > ? ? ? ?{ > ? ? ? ? ? ? ? ?.name = "spi0-1", > ? ? ? ? ? ? ? ?.pins = spi0_1_pins, > ? ? ? ? ? ? ? ?.num_pins = ARRAY_SIZE(spi0_1_pins), > ? ? ? ? ? ? ? ?.driver_data = &spi0_1_func, > ? ? ? ?}, > }; > > This would remove some boiler-plate code from the SoC drivers, > although it might be considered a bad breaking of abstraction barriers? Yes it does, however I didn't want to make the initial submission feature creepy. So I would like this to go in as is, then refactor drivers to get help from the framework later on, if we see that it is needed. (So the solution would evolve gradually rather than being too much designed-in from the beginning.) Do you think the driver support functions are needed from start? I could do it I think... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/