Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932893Ab1ERL1D (ORCPT ); Wed, 18 May 2011 07:27:03 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:38912 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932826Ab1ERL1B (ORCPT ); Wed, 18 May 2011 07:27:01 -0400 Date: Wed, 18 May 2011 12:26:47 +0100 From: Russell King - ARM Linux To: anish singh Cc: Catalin Marinas , lethal@linux-sh.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] trivial: Changed the printk loglevel when not able to allocate memory Message-ID: <20110518112647.GA15386@n2100.arm.linux.org.uk> References: <1305653342.2182.15.camel@anish-desktop> <1305713710.11468.39.camel@e102109-lin.cambridge.arm.com> <20110518112436.GH5913@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110518112436.GH5913@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 15 On Wed, May 18, 2011 at 12:24:36PM +0100, Russell King - ARM Linux wrote: > On Wed, May 18, 2011 at 04:27:47PM +0530, anish singh wrote: > > Got it.So should i change both as KERN_WARN and resend? > > Much better would be to change it to pr_warn() or even > dev_warn(&dev->dev, ...). Actually, make that pr_err() or dev_err(). Both printks in clcdfb_probe() are errors and so should be reported at error severity - they cause things to stop working and so they're not just a warning. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/