Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933152Ab1ERRAA (ORCPT ); Wed, 18 May 2011 13:00:00 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:47838 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932991Ab1ERQ75 (ORCPT ); Wed, 18 May 2011 12:59:57 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; b=g8a4OhTjSqu+Zz3/r7VIhiGFvSgclh6FwxI9VqDR9uaNIUwg7YUw/BF9hwnRgqiOkV XK8jSUft2upjeFum3WFcPiYJd929lUDigGZGbVfQqCzGNbGK9sDefeeV5b9+SimEL63a Fzp6K9s2wE+75jl29o5eckIqOCteqUTrfXpI8= MIME-Version: 1.0 In-Reply-To: <1305682604-21383-1-git-send-email-nab@linux-iscsi.org> References: <1305682604-21383-1-git-send-email-nab@linux-iscsi.org> From: Bart Van Assche Date: Wed, 18 May 2011 18:59:36 +0200 X-Google-Sender-Auth: AEOICQ2-Wo3v51m4pDRD1lWIYbg Message-ID: Subject: Re: [RFC] ib_srpt: initial .40-rc1 drivers/infiniband/ulp/srpt merge To: "Nicholas A. Bellinger" Cc: linux-kernel , linux-scsi , linux-rmda , Roland Dreier , Vu Pham , David Dillow , James Bottomley Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1043 Lines: 20 On Wed, May 18, 2011 at 3:36 AM, Nicholas A. Bellinger wrote: > ib_srpt: Convert se_wwn endpoint reference to struct srpt_port->port_wwn > http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=commitdiff;h=4e544a210acb227df1bb4ca5086e65bdf4e648ea Why has that change been implemented ? As far as I know InfiniBand HCAs have either one or two ports. If there are two ports present, at most one is active at any time. I don't see the point of making individual ports visible and configurable in configfs on the target instead of the HCA. If a user enables one port of a HCA but not the other, that could result in some really strange and hard to diagnose failures if the IB subnet manager decides to switch over to the other port. Or am I missing something ? Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/