Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933775Ab1ERT2F (ORCPT ); Wed, 18 May 2011 15:28:05 -0400 Received: from out5.smtp.messagingengine.com ([66.111.4.29]:57721 "EHLO out5.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933698Ab1ERT17 (ORCPT ); Wed, 18 May 2011 15:27:59 -0400 X-Sasl-enc: NrEz5igCQcbGlTETekITXu1B3Jk5Utd6DXsJSEBSbact 1305746878 Date: Wed, 18 May 2011 12:22:12 -0700 From: Greg KH To: Alessio Igor Bogani Cc: Rusty Russell , Tim Bird , Christoph Hellwig , Anders Kaseorg , Tim Abbott , LKML , Linux Embedded , Jason Wessel , Dirk Behme Subject: Re: your mail Message-ID: <20110518192212.GC26945@kroah.com> References: <4DD305B3.3000707@am.sony.com> <1305744925-8162-1-git-send-email-abogani@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1305744925-8162-1-git-send-email-abogani@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2153 Lines: 59 On Wed, May 18, 2011 at 08:55:25PM +0200, Alessio Igor Bogani wrote: > Dear Mr. Bird, Dear Mr. Kroah-Hartman, > > Sorry for my very bad English. > > 2011/5/18 Tim Bird : > [...] > > Alessio - do you have any timings you can share for the speedup? > > You can find a little benchmark using ftrace at end of this email: > https://lkml.org/lkml/2011/4/5/341 > > > On 05/17/2011 04:22 PM, Greg KH wrote: > >> On Tue, May 17, 2011 at 10:56:03PM +0200, Alessio Igor Bogani wrote: > >>> This work was supported by a hardware donation from the CE Linux Forum. > [...] > >> Please explain why you make a change, not just who sponsored the change, > >> that's not very interesting to developers. > > You are right. I apologize. > > This patch is a missing piece (not essential it is only a further little > optimization) of this little patchset: > https://lkml.org/lkml/2011/4/16/48 > > Unfortunately I forgot to include this patch in the series (my first error) > then I avoided explaining the changes because I had thought that those were > already enough explained in the cover-letter of the patchset (my second error). > > Sorry for my mistakes. > > Is this better? > > Subject: [PATCH] module: Use binary search in lookup_symbol() > > The function is_exported() with its helper function lookup_symbol() are used to > verify if a provided symbol is effectively exported by the kernel or by the > modules. Now that both have their symbols sorted we can replace a linear search > with a binary search which provide a considerably speed-up. > > This work was supported by a hardware donation from the CE Linux Forum. > > Signed-off-by: Alessio Igor Bogani Much better, I have no objection to this at all. Acked-by: Greg Kroah-Hartman Care to resend it without all the stuff above so someone (Rusty I guess) can apply it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/