Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752771Ab1ERT6n (ORCPT ); Wed, 18 May 2011 15:58:43 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:49136 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751723Ab1ERT6m (ORCPT ); Wed, 18 May 2011 15:58:42 -0400 MIME-Version: 1.0 In-Reply-To: <1305682865-27111-1-git-send-email-john.stultz@linaro.org> References: <1305682865-27111-1-git-send-email-john.stultz@linaro.org> From: Linus Torvalds Date: Wed, 18 May 2011 12:58:17 -0700 Message-ID: Subject: Re: [PATCH 0/4] v6 Improve task->comm locking situation To: John Stultz Cc: LKML , Joe Perches , Ingo Molnar , Michal Nazarewicz , Andy Whitcroft , Jiri Slaby , KOSAKI Motohiro , David Rientjes , Dave Hansen , Andrew Morton , linux-mm@kvack.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 33 On Tue, May 17, 2011 at 6:41 PM, John Stultz wrote: > > While this was brought up at the time, it was not considered > problematic, as the comm writing was done in such a way that > only null or incomplete comms could be read. However, recently > folks have made it clear they want to see this issue resolved. What folks? I don't think a new lock (or any lock) is at all appropriate. There's just no point. Just guarantee that the last byte is always zero, and you're done. If you just guarantee that, THERE IS NO RACE. The last byte never changes. You may get odd half-way strings, but you've trivially guaranteed that they are C NUL-terminated, with no locking, no memory ordering, no nothing. Anybody who asks for any locking is just being a silly git. Tell them to man the f*ck up. So I'm not going to apply anything like this for 2.6.39, but I'm also not going to apply it for 40 or 41 or anything else. I refuse to accept just stupid unnecessary crap. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/