Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932433Ab1ESLiu (ORCPT ); Thu, 19 May 2011 07:38:50 -0400 Received: from mail-qy0-f174.google.com ([209.85.216.174]:54235 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932253Ab1ESLit (ORCPT ); Thu, 19 May 2011 07:38:49 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=FDzw60aUdO9sz5ZtmwW3aJg+BXMOwwFexbIn2uQn6IH62ZPTxkRZJzd78GkYOIGIme IRnKgHt86Ms0zP9gtL5ChAWe8H83x79d0PCFApbOkmyLGfZ9Po47LUddau0SafwT5trs 9i8vJyeRmwebjyy2KBVilJlyk050YWV56mxL8= MIME-Version: 1.0 In-Reply-To: References: <1303910002-3333-1-git-send-email-linus.walleij@stericsson.com> From: Barry Song <21cnbao@gmail.com> Date: Thu, 19 May 2011 19:38:27 +0800 Message-ID: Subject: Re: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio To: Linus Walleij Cc: Grant Likely , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Lee Jones , Jonas Aaberg Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 18 > -arch_initcall(u300_gpio_init); > -module_exit(u300_gpio_exit); > looks like the driver can't be a real module, is the module_exit suitable? it looks strange module_exit plays together with arch_initcall. guess symbol u300_gpio_exit will finally lose in the last vmlinux since it is in exit section and built-in kernel. another problem i see is after moving gpio/pinmux to drivers as platform device, codes in arch/arm/plat(mach) can't call gpio/pinmux api before the related platform devices registerred. that will required these platform devices enter system earlier. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/