Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757045Ab1ESOHp (ORCPT ); Thu, 19 May 2011 10:07:45 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:61590 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756953Ab1ESOHn (ORCPT ); Thu, 19 May 2011 10:07:43 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=uBJXxLW8U4BwedrD9kUlJ2drWS1IGrzRhxssniAWTxG4uvwt1jAHisQIgzpGoH2PeQ zLpsi70oXXKxHEaDZmdP+1YyoNfMPhM+566iQ7+ocrlgvpSXA2r81x1MCaLtjY8ouD34 Xzpj3qSycbpklAPJ8rLLuHLuYqKByNhT6LcHo= Date: Thu, 19 May 2011 16:07:38 +0200 From: Frederic Weisbecker To: Jiri Olsa Cc: Greg KH , Alan Cox , Alan Cox , Kay Sievers , Arnd Bergmann , LKML Subject: Re: BUG: NULL pointer deref in tty port / uart Message-ID: <20110519140735.GA1956@nowhere> References: <20110517231229.GB1776@nowhere> <20110518004420.2b8f5da9@bob.linux.org.uk> <20110518142631.GB2011@jolsa.brq.redhat.com> <20110518153636.5cdcdd78@lxorguk.ukuu.org.uk> <20110518144429.GC2011@jolsa.brq.redhat.com> <20110518155033.2773b323@bob.linux.org.uk> <20110518194212.GA27758@suse.de> <20110519111901.GC2061@jolsa.brq.redhat.com> <20110519125120.GA12844@suse.de> <20110519135829.GA1976@jolsa.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110519135829.GA1976@jolsa.brq.redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2173 Lines: 56 On Thu, May 19, 2011 at 03:58:29PM +0200, Jiri Olsa wrote: > On Thu, May 19, 2011 at 05:51:20AM -0700, Greg KH wrote: > > On Thu, May 19, 2011 at 01:19:01PM +0200, Jiri Olsa wrote: > > > On Wed, May 18, 2011 at 12:42:12PM -0700, Greg KH wrote: > > > > On Wed, May 18, 2011 at 03:50:33PM +0100, Alan Cox wrote: > > > > > > I think it's the > > > > > > > > > > > > uart_update_termios in uart_dtr_rts (drivers/tty/serial/serial_core.c) > > > > > > > > > > > > called path: > > > > > > > > > > > > tty_port_block_til_ready > > > > > > tty_port_raise_dtr_rts > > > > > > uart_dtr_rts > > > > > > uart_update_termios > > > > > > > > > > Ah that would explain why I can't find and dup it - it isn't found in > > > > > the current -next tree. > > > > > > > > > > > > > > > c7d7abff40c27f82fe78b1091ab3fad69b2546f9 (and thereafter) > > > > > > > > > > Jiri Slaby fixed it in sorting out uart_startup > > > > > > > > > > I guess these should now get tagged for -stable. > > > > > > > > So that would be the following patches in the linux-next tree: > > > > c7d7abff40c27f82fe78b1091ab3fad69b2546f9 serial: core, move termios handling to uart_startup > > > > 303a7a1199c20f7c9452f024a6e17bf348b6b398 serial: core, do not set DTR/RTS twice on startup > > > > 6f5c24ad0f7619502199185a026a228174a27e68 serial: core, remove uart_update_termios > > > > > > > > right? > > > > > > > > Anything else need to be backported? > > > > > > > > Frederic, can you test that these 3 patches solve the problem for you? > > > > If you want, I can send them to you separately if you don't have a copy > > > > of linux-next around anywhere. > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > I tried linux-next and cannot hit the issue anymore > > > > That's great, but can you try .38 or .39 with those patches above and > > verify that they solve the problem? > > yes, this works for me as well Thanks for your test! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/