Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933467Ab1ESQXD (ORCPT ); Thu, 19 May 2011 12:23:03 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:52940 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932238Ab1ESQXB (ORCPT ); Thu, 19 May 2011 12:23:01 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=FYd+KF4jgvmXpa6vIcev4MQI0BPkn5wPmD46f9nVLxYvKnT8IQyH7R5llTzuoCrjoS n1kcYjUHw7TMMfwMfJhJmjzTYQREwcedAw2EgcM+3JXcpVC6L5lSmIeOmu94s5jYvOSZ AEJU7DCvLNh3Hd5cFXYO4JDs+0S5MhlGn1+9M= MIME-Version: 1.0 In-Reply-To: <20110518135823.a809f829.sfr@canb.auug.org.au> References: <20110518114912.dfdf8835.sfr@canb.auug.org.au> <1305684362.2856.349.camel@haakon2.linux-iscsi.org> <20110518135823.a809f829.sfr@canb.auug.org.au> Date: Thu, 19 May 2011 18:22:59 +0200 X-Google-Sender-Auth: IL0BNeHEotis9oQLQHY9Lv9g-dw Message-ID: Subject: Re: linux-next: build warning after merge of the scsi tree From: Geert Uytterhoeven To: Stephen Rothwell Cc: "Nicholas A. Bellinger" , James Bottomley , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Kiran Patil , Joe Eykholt , Christoph Hellwig , Yi Zou Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id p4JGNCuX010456 Content-Length: 1588 Lines: 30 On Wed, May 18, 2011 at 05:58, Stephen Rothwell wrote: >> --- a/drivers/target/tcm_fc/tfc_io.c >> +++ b/drivers/target/tcm_fc/tfc_io.c >> @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd) >>                                                 "xid <0x%x>, remaining <0x%x>, " >>                                                 "lso_max <0x%x>\n", >>                                                 __func__, fp, ep->xid, >> -                                               remaining, lport->lso_max); >> +                                               (unsigned int)remaining, >> +                                               lport->lso_max); > > Given that "remaining" really is a length, surely it makes more sense to Exactly my comments ... > print it with %zd than to cast it and print it with %x ... ... except that size_t is unsigned, so %zu would be a little bit better. Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?