Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935302Ab1ETFTJ (ORCPT ); Fri, 20 May 2011 01:19:09 -0400 Received: from mga01.intel.com ([192.55.52.88]:23770 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287Ab1ETFTH (ORCPT ); Fri, 20 May 2011 01:19:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,240,1304319600"; d="scan'208";a="5036766" Subject: Re: Perfromance drop on SCSI hard disk From: "Alex,Shi" To: Shaohua Li Cc: Jens Axboe , "James.Bottomley@hansenpartnership.com" , "linux-kernel@vger.kernel.org" In-Reply-To: References: <1305009600.21534.587.camel@debian> <4DCC4340.6000407@fusionio.com> <1305247704.2373.32.camel@sli10-conroe> <1305255717.2373.38.camel@sli10-conroe> <1305533054.2375.45.camel@sli10-conroe> <1305535071.21534.2122.camel@debian> <1305612565.21534.2177.camel@debian> <4DD221BE.3040406@fusionio.com> <1305793580.22968.155.camel@debian> <4DD56104.6080801@fusionio.com> <1305850920.22968.1089.camel@debian> Content-Type: text/plain; charset="UTF-8" Date: Fri, 20 May 2011 13:17:43 +0800 Message-ID: <1305868663.4866.8.camel@debian> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3067 Lines: 67 On Fri, 2011-05-20 at 08:40 +0800, Shaohua Li wrote: > 2011/5/20 Alex,Shi : > > On Fri, 2011-05-20 at 02:27 +0800, Jens Axboe wrote: > >> On 2011-05-19 10:26, Alex,Shi wrote: > >> > > >> >> I will queue up the combined patch, it looks fine from here as well. > >> >> > >> > > >> > When I have some time to study Jens and shaohua's patch today. I find a > >> > simpler way to resolved the re-enter issue on starved_list. Following > >> > Jens' idea, we can just put the starved_list device into kblockd if it > >> > come from __scsi_queue_insert(). > >> > It can resolve the re-enter issue and recover performance totally, and > >> > need not a work_struct in every scsi_device. The logic/code also looks a > >> > bit simpler. > >> > What's your opinion of this? > >> > >> Isn't this _identical_ to my original patch, with the added async run of > >> the queue passed in (which is important, an oversight)? > > > > Not exactly same. It bases on your patch, but added a bypass way for > > starved_list device. If a starved_list device come from > > __scsi_queue_insert(), that may caused by our talking recursion, kblockd > > with take over the process. Maybe you oversight this point in original > > patch. :) > > > > The different part from yours is below: > > --- > > static void __scsi_run_queue(struct request_queue *q, bool async) > > { > > struct scsi_device *sdev = q->queuedata; > > struct Scsi_Host *shost; > > @@ -435,30 +437,35 @@ static void scsi_run_queue(struct request_queue > > *q) > > &shost->starved_list); > > continue; > > } > > - > > - spin_unlock(shost->host_lock); > > - spin_lock(sdev->request_queue->queue_lock); > > - __blk_run_queue(sdev->request_queue); > > - spin_unlock(sdev->request_queue->queue_lock); > > - spin_lock(shost->host_lock); > > + if (async) > > + blk_run_queue_async(sdev->request_queue); > > + else { > > + spin_unlock(shost->host_lock); > > + spin_lock(sdev->request_queue->queue_lock); > > + __blk_run_queue(sdev->request_queue); > > + spin_unlock(sdev->request_queue->queue_lock); > > + spin_lock(shost->host_lock); > >> > I don't quite like this approach. blk_run_queue_async() could > introduce fairness issue as I said in previous mail, because we drop > the sdev from starved list but didn't run its queue immediately. The > issue exists before, but it's a bug to me. I understand what's your worried. But not quite clear of the trigger scenario. anyway, it is still a potential issue of fairness exist. So forget my patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/