Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933482Ab1ETGc5 (ORCPT ); Fri, 20 May 2011 02:32:57 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:49333 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933024Ab1ETGc4 (ORCPT ); Fri, 20 May 2011 02:32:56 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :date:message-id:mime-version:x-mailer:content-transfer-encoding; b=HVhn2/X/x67QeOgD16KwJ5FMPwcKI1cQHVtTu60540dAO0p3DmAjAc28yTxDyeehsC uyG59VnjsrADiKHOSeqbPhaqDKQgkTRv/qsfN3Yx7O/W6HsuUIX8Mm+Qw+kz68MF0yJc QxhaNvyKJ0Z3oItSCT04KouHbSjlAF1vLO0aI= Subject: Re: [PATCH] UBIFS: don't fail on -EBADMSG when fixing free space From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Ben Gardiner Cc: "Matthew L. Creech" , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: References: <1305196419.2713.84.camel@localhost> <1305751647-3122-1-git-send-email-bengardiner@nanometrics.ca> Content-Type: text/plain; charset="UTF-8" Date: Fri, 20 May 2011 09:29:05 +0300 Message-ID: <1305872945.2630.119.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 (2.32.2-1.fc14) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 992 Lines: 22 On Thu, 2011-05-19 at 09:28 -0400, Ben Gardiner wrote: > So, at least on my hardware, the -74 error is expected when the 0xff > pages are not dropped and so without the 'err != -EBADMSG' exception > the free space fixup will cause the volume to fail mount for me: Still confused. If you have empty and erased flash, then you program it with all 0xFFs, you should be able to read it with no errors. If this is not the case for you, you should fix the driver. UBIFS cannot help in this case - we consider it as "broken flash driver" case. I have not read your e-mail carefully because of limited amount of time, but with quick reading I became confused - too much information :-) -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/