Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666Ab1ETHBb (ORCPT ); Fri, 20 May 2011 03:01:31 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:43567 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492Ab1ETHBa (ORCPT ); Fri, 20 May 2011 03:01:30 -0400 Date: Fri, 20 May 2011 01:01:27 -0600 From: Grant Likely To: Sascha Hauer Cc: Shawn Guo , Linus Walleij , Linus Walleij , Jonas Aaberg , linux-kernel@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio Message-ID: <20110520070127.GD21285@ponder.secretlab.ca> References: <1303910002-3333-1-git-send-email-linus.walleij@stericsson.com> <20110519085638.GA26816@S2100-06.ap.freescale.net> <20110519135631.GB26816@S2100-06.ap.freescale.net> <20110519191156.GE2429@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110519191156.GE2429@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1723 Lines: 37 On Thu, May 19, 2011 at 09:11:56PM +0200, Sascha Hauer wrote: > On Thu, May 19, 2011 at 09:56:32PM +0800, Shawn Guo wrote: > > On Thu, May 19, 2011 at 02:21:27PM +0200, Linus Walleij wrote: > > > On Thu, May 19, 2011 at 10:56 AM, Shawn Guo wrote: > > > > > > > I start working on moving mxs gpio (arch/arm/mach-mxs/gpio.c) into > > > > driver/gpio, and I see the possibility to go a different approach > > > > from U300 one posted here. > > > > > > I've tried to figure out what relation the mail has to the U300 driver > > > but cannot find any, more than that it's moving a driver... Please > > > start a new mail thread. > > > > > I will post mxs-gpio driver once I get it done. Then please review > > the code and see the difference between mxs-gpio and u300-gpio, > > though these hardwares have something in common. > > I'm pretty sure they have something in common and even more that *all* > gpio drivers have something in common. I wonder if it really makes sense > to move the gpio driver to drivers/gpio without creating a common > mmio_gpio_chip beforehand. This can't be very hard. already done and queued for 2.6.39. It may not be in it's final form, and I'll possibly change the name, but take a look at the bgpio_chip patches that were circulated on the list, and will be in my gpio/next branch on git://git.secretlab.ca/git/linux-2.6 That said, I don't mind moving stuff into drivers/gpio first and consolidating it after. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/