Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935045Ab1ETIfJ (ORCPT ); Fri, 20 May 2011 04:35:09 -0400 Received: from cantor.suse.de ([195.135.220.2]:38727 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934897Ab1ETIfC (ORCPT ); Fri, 20 May 2011 04:35:02 -0400 Date: Fri, 20 May 2011 10:35:00 +0200 (CEST) From: Jiri Kosina To: Benjamin Tissoires Cc: Dmitry Torokhov , Henrik Rydberg , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] hid-multitouch: class MT_CLS_STANTUM is redundant with MT_CLS_CONFIDENCE In-Reply-To: <1305807498-8785-7-git-send-email-benjamin.tissoires@enac.fr> Message-ID: References: <1305807498-8785-1-git-send-email-benjamin.tissoires@enac.fr> <1305807498-8785-7-git-send-email-benjamin.tissoires@enac.fr> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1298 Lines: 38 On Thu, 19 May 2011, Benjamin Tissoires wrote: > Stantum devices used to work with MT_CLS_STANTUM but MT_CLS_CONFIDENCE > is exactly the same. This patch switches them to this generic class, > and remove the unused MT_CLS_STANTUM. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/hid-multitouch.c | 9 +++------ > 1 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index feeb0b7..65b92d2 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -88,7 +88,6 @@ struct mt_class { > #define MT_CLS_DUAL_INRANGE_CONTACTNUMBER 3 > #define MT_CLS_CYPRESS 4 > #define MT_CLS_EGALAX 5 > -#define MT_CLS_STANTUM 6 > #define MT_CLS_3M 7 > #define MT_CLS_CONFIDENCE 8 > #define MT_CLS_CONFIDENCE_MINUS_ONE 9 Benjamin, is it intentional that you are leaving the hole in the numbering here? I don't think there would be any issue with re-numbering 7-10, would it? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/