DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:from:date
         :x-google-sender-auth:message-id:subject:to:cc:content-type
         :content-transfer-encoding;
        b=OCFZ30Abr/s7UGKCtQWK8ipOYH+kljOePXrY0MUA+jqqksMKUuyFvDWuZmB5nGWnM6
         1F/PCHuYHkFPITcYXE21Ro9nIuQlhBUKOVmiFfFso9XIslFKaVNos8V5bmpTLa57lWeH
         Vl+Ze/WL25b92tVNpXmX8+ybM+f3zyVdgMbA4=
MIME-Version: 1.0
In-Reply-To: <20110519163709.GH3702@shadowen.org>
References: <1305635452-14835-1-git-send-email-miklos@szeredi.hu> <20110519163709.GH3702@shadowen.org>
From: Michal Suchanek <hramrach@centrum.cz>
Date: Fri, 20 May 2011 10:56:38 +0200
Message-ID: <BANLkTikeZmS=xX0hBizwQ49k8uTOQh3BAA@mail.gmail.com>
Subject: Re: [PATCH 0/7] overlay filesystem v9
To: Andy Whitcroft <apw@canonical.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, viro@zeniv.linux.org.uk,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, nbd@openwrt.org, neilb@suse.de,
        jordipujolp@gmail.com, mszeredi@suse.cz
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1924
Lines: 44

Hello

On 19 May 2011 18:37, Andy Whitcroft <apw@canonical.com> wrote:
> On Tue, May 17, 2011 at 02:30:45PM +0200, Miklos Szeredi wrote:
>
>> Here's an updated version of the overlay filesystem.
>>
>> Git tree is here:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs.v9
>
> Ok I pulled this into the Ubuntu kernel and made an Ubuntu Live CD
> for testing.  Overall it worked pretty well, no hangs, no crashes,
> performance seemed reasonable.  We hit one issue with hard links which
> fail to be possible on overlayfs mounts when the Yama LSM (out of tree)
> is enabled.  This module applies more aggressive checks on hard-links
> preventing links to files you cannot read.
>
> The bug seems to be related to the way we handle user and group owners for
> the overlayfs inodes, which we do not initialise (and they remain as 0,0).
> While these ownerships are never exposed to userspace they are exposed
> to the LSM layer, and the LSM module checks the wrong owner and fails
> to allow the links.
>
> From what I can see it is completly reasonable to initialise the ownership
> fields in the overlayfs inode from the underlying inode, or for new files
> ones initialise it in the normal way based on the containing directory.

If the ownership recorded in the inode is not user visible then the
ownership must be taken elsewhere (the lower filesystem?) . Since
deconstructing, modifying and reconstructing the overlay is supported
initializing the inode to some default gives you two possibly
inconsistent ownerships - one seen by LSM, the other by userspace.

So in general LSM should check whatever userspace would I guess.

Thanks

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/