Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935648Ab1ETLsn (ORCPT ); Fri, 20 May 2011 07:48:43 -0400 Received: from mailrelay001.isp.belgacom.be ([195.238.6.51]:63264 "EHLO mailrelay001.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935453Ab1ETLsl (ORCPT ); Fri, 20 May 2011 07:48:41 -0400 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAMVU1k1R8tSW/2dsb2JhbACmGniIcLtuDoYLBJc8h0w Date: Fri, 20 May 2011 13:48:39 +0200 From: Wim Van Sebroeck To: Nat Gurumoorthy Cc: Jean Delvare , Guenter Roeck , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, mikew@google.com Subject: Re: [PATCH v9 1/2] Use "request_muxed_region" in it87 watchdog drivers Message-ID: <20110520114839.GS17887@infomag.iguana.be> References: <1304745564-13003-1-git-send-email-natg@google.com> <1304745647-13051-1-git-send-email-natg@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1304745647-13051-1-git-send-email-natg@google.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 27 Hi Nat, > 01 - Changes to it87 watchdog driver to use "request_muxed_region" > Serialize access to the hardware by using "request_muxed_region" macro defined > by Alan Cox. Call to this macro will hold off the requestor if the resource is > currently busy. > > The use of the above macro makes it possible to get rid of > spinlocks in it8712f_wdt.c and it87_wdt.c watchdog drivers. > This also greatly simplifies the implementation of it87_wdt.c driver. > > "superio_enter" will return an error if call to "request_muxed_region" fails. > Rest of the code change is to ripple an error return from superio_enter to > the top level. > > Signed-off-by: Nat Gurumoorthy Added to linux-2.6-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/