Date: Fri, 20 May 2011 15:04:17 +0200
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: James.Bottomley@suse.de, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH]: Fix Ultrastor asm snippet
Message-ID: <20110520130417.GO5077@const.bordeaux.inria.fr>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Christoph Hellwig <hch@infradead.org>, James.Bottomley@suse.de,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	akpm@linux-foundation.org
References: <20110518150605.GA25262@const.bordeaux.inria.fr> <20110520130215.GB3428@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20110520130215.GB3428@infradead.org>
User-Agent: Mutt/1.5.12-2006-07-14
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 882
Lines: 29

Christoph Hellwig, le Fri 20 May 2011 09:02:15 -0400, a ?crit :
> On Wed, May 18, 2011 at 05:06:05PM +0200, Samuel Thibault wrote:
> > Commit 1292500b replaced
> > 
> > "=m" (*field) : "1" (*field)
> > 
> > with
> > 
> > "=m" (*field) :
> > 
> > with comment "The following patch fixes it by using the '+' operator on
> > the (*field) operand, marking it as read-write to gcc."
> > '+' was actually forgotten.  This really puts it.
> 
> Do you actually have the hardware or was this just a code audit?

Just a code audit.

> I have the strong suspicion that this driver is pretty much dead and
> bitrotting.

Most probably, yes.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/