Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934240Ab1ETPlW (ORCPT ); Fri, 20 May 2011 11:41:22 -0400 Received: from lennier.cc.vt.edu ([198.82.162.213]:59260 "EHLO lennier.cc.vt.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756141Ab1ETPlU (ORCPT ); Fri, 20 May 2011 11:41:20 -0400 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.3-dev To: Jian Peng Cc: "Rafael J. Wysocki" , Tejun Heo , Jeff Garzik , Michael Leun , linux-ide@vger.kernel.org, Linux PM mailing list , LKML Subject: Re: [PATCH v2.6.38-rc7] Revert "libata: ahci_start_engine compliant to AHCI spec" In-Reply-To: Your message of "Wed, 18 May 2011 17:14:56 PDT." From: Valdis.Kletnieks@vt.edu References: <201105120025.34531.rjw@sisk.pl> <20633.1305565337@localhost> <201105182144.37713.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1305906020_2669P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Fri, 20 May 2011 11:40:20 -0400 Message-ID: <10124.1305906020@localhost> X-Mirapoint-Received-SPF: 198.82.161.152 auth3.smtp.vt.edu Valdis.Kletnieks@vt.edu 2 pass X-Mirapoint-IP-Reputation: reputation=neutral-1, source=Fixed, refid=n/a, actions=MAILHURDLE SPF TAG X-Junkmail-Status: score=10/50, host=zidane.cc.vt.edu X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A020201.4DD68B66.014B,ss=1,fgs=0, ip=0.0.0.0, so=2010-07-22 22:03:31, dmn=2009-09-10 00:05:08, mode=single engine X-Junkmail-IWF: false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1272 Lines: 43 --==_Exmh_1305906020_2669P Content-Type: text/plain; charset=us-ascii On Wed, 18 May 2011 17:14:56 PDT, Jian Peng said: > > @@ -1353,6 +1332,8 @@ > > > > > > ahci_start_engine(ap); > > > > + msleep(5); > > + > > if (online) > > > > *class = ahci_dev_classify(ap); > > It may very well be that adding a magic msleep(5) here just Makes It Work, but I have a gut feeling that it's in the wrong place (for starters, 'online' can't change during the msleep() unless somebody *else* sets it - in which case the locking is screwed up as we're not forcing a re-read of the value). The msleep() probably needs to be before something else further down in the code (but I have no idea exactly what). --==_Exmh_1305906020_2669P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Exmh version 2.5 07/13/2001 iD8DBQFN1otkcC3lWbTT17ARAkbWAKCcDK9WjpHXKaCoOJFCpWMpU1POgQCfZPkw A7iqndZ6E+a9fXTQ8HEUA4E= =1r68 -----END PGP SIGNATURE----- --==_Exmh_1305906020_2669P-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/