Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934757Ab1ETQCj (ORCPT ); Fri, 20 May 2011 12:02:39 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:61471 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757040Ab1ETQCh (ORCPT ); Fri, 20 May 2011 12:02:37 -0400 MIME-Version: 1.0 X-Originating-IP: [93.172.116.29] In-Reply-To: <1305321990-22041-2-git-send-email-balbi@ti.com> References: <1305321990-22041-1-git-send-email-balbi@ti.com> <1305321990-22041-2-git-send-email-balbi@ti.com> From: Ohad Ben-Cohen Date: Fri, 20 May 2011 19:02:15 +0300 Message-ID: Subject: Re: [RFC/PATCH 01/13] net: wl12xx: sdio: id_tables should be __devinitconst To: Felipe Balbi Cc: Luciano Coelho , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 866 Lines: 20 On Sat, May 14, 2011 at 12:26 AM, Felipe Balbi wrote: > That's only needed during init anyway, let's free > some space after we're done probing. sdio devices are dynamically created whenever the hw is plugged into the mmc slot by the user. that can happen anytime while the system is up, not only during init. > -static const struct sdio_device_id wl1271_devices[] = { > +static const struct sdio_device_id wl1271_devices[] __devinitconst = { it looks to me that sdio_match_device is going to be surprised if ->id_table won't be valid. i wouldn't do this, unless you have a good explanation otherwise. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/