Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372Ab1EUFP4 (ORCPT ); Sat, 21 May 2011 01:15:56 -0400 Received: from barracuda.fsl.cs.sunysb.edu ([130.245.126.20]:50797 "EHLO barracuda.fsl.cs.sunysb.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229Ab1EUFPu (ORCPT ); Sat, 21 May 2011 01:15:50 -0400 X-ASG-Debug-ID: 1305954948-01c65a06b01704f0001-xx1T2L X-Barracuda-Envelope-From: ezk@fsl.cs.sunysb.edu X-Barracuda-RBL-Trusted-Forwarder: 130.245.126.16 Subject: Re: [PATCH 5/7] overlay filesystem (inode.c bad error path) X-Barracuda-BWL-IP: 192.168.1.136 X-Barracuda-BBL-IP: 192.168.1.136 X-Barracuda-RBL-IP: 192.168.1.136 Mime-Version: 1.0 (Apple Message framework v1084) X-ASG-Orig-Subj: Re: [PATCH 5/7] overlay filesystem (inode.c bad error path) Content-Type: text/plain; charset=us-ascii From: Erez Zadok In-Reply-To: Date: Sat, 21 May 2011 01:15:46 -0400 Cc: "viro@ZenIV.linux.org.uk" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "apw@canonical.com" , "nbd@openwrt.org" , "neilb@suse.de" , "hramrach@centrum.cz" , "jordipujolp@gmail.com" Content-Transfer-Encoding: 7bit Message-Id: References: <1305635452-14835-1-git-send-email-miklos@szeredi.hu> <103d3f78e2d3478d8bb93f5dda3a4a08@HUBCAS1.cs.stonybrook.edu> To: Miklos Szeredi X-Mailer: Apple Mail (2.1084) X-Barracuda-Connect: avatar.fsl.cs.sunysb.edu[130.245.126.16] X-Barracuda-Start-Time: 1305954948 X-Barracuda-URL: http://130.245.126.20:8000/cgi-mod/mark.cgi X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.64350 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1392 Lines: 38 On May 20, 2011, at 10:25 AM, Miklos Szeredi wrote: > Erez Zadok writes: >> Niklos, I forgot to mention that I had to apply a small fix to a VFS >> bug in fs/namei.c:1362, where a mix of symlinks and renames, using >> racer, triggers an BUG_ON at the VFS layer (very reproducible). >> Without this fix, racer oopses in the VFS well before it gets to >> trigger overlayfs bugs. It's a pity 2.6.39 was released with this >> very reproducible *VFS* level bug (doesn't anyone run racer+fsx+ltp >> before releasing a new kernel?) >> >> Anyway, here's the small patch here. Clearly viro/hch need to review >> this "fix" b/c I'm not sure it's really the right one > > Patch looks good to me. > > Acked-by: Miklos Szeredi > > If you've got a patch fixing a serious bug, you'd better send it to > Linus and Andrew (as well as the VFS maintainers), where it'll get more > prompt evaluation. > > You can still do that, also adding "CC: stable@kernel.org" to the SOB > block in the patch so that the fix quickly makes it into the 2.6.39 > stable series. > > Thanks, > Miklos Thanks. I'll do that. Erez. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/