Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756883Ab1EURs4 (ORCPT ); Sat, 21 May 2011 13:48:56 -0400 Received: from mail.perches.com ([173.55.12.10]:1828 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755552Ab1EURsp (ORCPT ); Sat, 21 May 2011 13:48:45 -0400 From: Joe Perches To: Ben Greear , linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, "David S. Miller" , Arnd Bergmann , netdev@vger.kernel.org Subject: [PATCH 2/2] net: filter: Use WARN_RATELIMIT Date: Sat, 21 May 2011 10:48:40 -0700 Message-Id: X-Mailer: git-send-email 1.7.5.rc3.dirty In-Reply-To: <1305666832.1722.62.camel@Joe-Laptop> References: <1305666832.1722.62.camel@Joe-Laptop> In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 959 Lines: 33 A mis-configured filter can spam the logs with lots of stack traces. Rate-limit the warnings and add printout of the bogus filter information. Original-patch-by: Ben Greear Signed-off-by: Joe Perches --- net/core/filter.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index 0eb8c44..0e3622f 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -350,7 +350,9 @@ load_b: continue; } default: - WARN_ON(1); + WARN_RATELIMIT(1, "Unknown code:%u jt:%u tf:%u k:%u\n", + fentry->code, fentry->jt, + fentry->jf, fentry->k); return 0; } } -- 1.7.5.rc3.dirty -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/