Date: Sun, 22 May 2011 21:20:42 +0100 (IST)
From: Dave Airlie <airlied@linux.ie>
To: Andi Kleen <andi@firstfloor.org>
cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 01/12] Force always inline for gcc 4.5 when optimizing
 for size
In-Reply-To: <f21331d6ac687d28aa7f9b7f0f5b7620.squirrel@www.firstfloor.org>
Message-ID: <alpine.DEB.2.00.1105222115270.8205@skynet.skynet.ie>
References: <1305936082-21304-1-git-send-email-andi@firstfloor.org>    <alpine.DEB.2.00.1105220816480.12897@skynet.skynet.ie> <f21331d6ac687d28aa7f9b7f0f5b7620.squirrel@www.firstfloor.org>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1133
Lines: 25


> > Oh these look like a good plan, one of our contributors has an inline
> > fetish and it got cut-n-pasted into a few places particular in radeon.
> >
> > But we won't be turning DRM debugging off, its what we use to debug things
> > in the field, I did get a patch recently to reduce some of its overhead
> 
> Why can't it be a CONFIG option like all other debugging code?

Not sure which part of debug things in the field doesn't explain it, 
having people remove the debugging code would sort of work against fixing 
problems. Having a config option might be possible, but then I'd have to 
deal with people who think they know what they are doing turning it off, 
so I'd rather not. Next think you know some distro turns it off and you 
have users who you can't help anymore.

> If you want to keep it on would need to drop even more inlines to get
> the 50k overhead down.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/