Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756087Ab1EWQLs (ORCPT ); Mon, 23 May 2011 12:11:48 -0400 Received: from mail.perches.com ([173.55.12.10]:1858 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754837Ab1EWQLr (ORCPT ); Mon, 23 May 2011 12:11:47 -0400 Subject: Re: [patch v3] checkpatch: Signature format verification From: Joe Perches To: anish Cc: davej@redhat.com, rostedt@goodmis.org, apw@shadowen.org, akpm@linux-foundation.org, vapier@gentoo.org, linux-kernel@vger.kernel.org, man.k1983@gmail.com In-Reply-To: <1306164094.2292.25.camel@anish-desktop> References: <1306006721.1622.18.camel@anish-desktop> <1306059528.2761.3.camel@anish-desktop> <1306164094.2292.25.camel@anish-desktop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 23 May 2011 09:11:45 -0700 Message-ID: <1306167105.8687.11.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 34 On Mon, 2011-05-23 at 20:51 +0530, anish wrote: > From: anish kumar > This patch generates warning when there is no space between > the patch submitter and successive mail-id. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > + if (!($line =~ /^\s*$sign/)) { if ($line !~ /etc...) > + WARN("$sign is the preferred form\n" . > + $herecurr); > + } > + if ($line =~ /^\s*$sign(.*)/i) { > + if($1 !~ /^\s*(\s[a-zA-Z]*.*)/i) { Email addresses may start with a quote (") or a digit. Space between if and ( > + WARN("Space required after $sign\n" . > + $herecurr); > + } > + if($1 !~ /[\sa-zA-Z]+\s<.*>/i) { Space between if and ( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/