Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756452Ab1EWQXE (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 May 2011 12:23:04 -0400
Received: from mail.perches.com ([173.55.12.10]:1862 "EHLO mail.perches.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756026Ab1EWQXC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 May 2011 12:23:02 -0400
Subject: Re: [PATCH]net:8021q:vlan.c Fix pr_info to read on line in the
 syslog.
From: Joe Perches <joe@perches.com>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org
In-Reply-To: <1306166698-2036-1-git-send-email-justinmattock@gmail.com>
References: <1306166698-2036-1-git-send-email-justinmattock@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 23 May 2011 09:23:01 -0700
Message-ID: <1306167781.8687.20.camel@Joe-Laptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.2 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1848
Lines: 54

On Mon, 2011-05-23 at 09:04 -0700, Justin P. Mattock wrote:
> The patch below changes the pr_info so that it reads on one line in the syslog
> rather than two.
> 
> before:
> 
> [   30.438203] 802.1Q VLAN Support v1.8 Ben Greear <greearb@candelatech.com>
> [   30.441542] All bugs added by David S. Miller <davem@redhat.com>
> 
> 
> after:
> [   29.356282] 802.1Q VLAN Support v1.8 Ben Greear <greearb@candelatech.com> All bugs added by: David S. Miller <davem@redhat.com>
> 
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> 
> ---
>  net/8021q/vlan.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index b2274d1..02f4d8b 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -673,8 +673,8 @@ static int __init vlan_proto_init(void)
>  {
>  	int err;
>  
> -	pr_info("%s v%s %s\n", vlan_fullname, vlan_version, vlan_copyright);
> -	pr_info("All bugs added by %s\n", vlan_buggyright);
> +	pr_info("%s v%s %s All bugs added by: %s\n", vlan_fullname, vlan_version, 
> +		vlan_copyright, vlan_buggyright);

Might as well avoid the format string then too.

	pr_info(vlan_fullname " v" vlan_version " " vlan_copyright
		" All bugs added by: " vlan_buggyright "\n");
 
or just kill the otherwise unused vlan_<foo> variables

	pr_info("802.1Q VLAN Support v" vlan_version
		" Ben Greear <greearb@candelatech.com>"
		" All bugs added by: David S. Miller <davem@redhat.com>\n");

though I think that emitting names on startup isn't necessary and
this is enough:

	pr_info("802.1Q VLAN Support v" vlan_version "\n");


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/