Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757010Ab1EWS4J (ORCPT ); Mon, 23 May 2011 14:56:09 -0400 Received: from mail.avalus.com ([89.16.176.221]:41637 "EHLO mail.avalus.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755722Ab1EWS4H (ORCPT ); Mon, 23 May 2011 14:56:07 -0400 Date: Mon, 23 May 2011 19:56:03 +0100 From: Alex Bligh Reply-To: Alex Bligh To: Christoph Hellwig , Jan Kara cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Andrew Morton , Andreas Dilger , "Theodore Ts'o" , Alex Bligh Subject: Re: BUG: Failure to send REQ_FLUSH on unmount on ext3, ext4, and FS in general Message-ID: In-Reply-To: <20110523173350.GA10554@infradead.org> References: <959E4E25EAEC544D31199E6F@nimrod.local> <20110523155550.GE4716@quack.suse.cz> <20110523172906.GH4716@quack.suse.cz> <20110523173350.GA10554@infradead.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 25 --On 23 May 2011 13:33:50 -0400 Christoph Hellwig wrote: > It really should be changed. The previous (bad) excuse was that the > ordering barrier code was too much overhead. Making a filesystem > non-safe by default is already a bad sin, but having the code to make > it safe around and not enabling it is plain criminal. At risk of wandering into ext3 default flamewar, I suppose people foolishly or not might want to live dangerously. If I'm creating an image on a loopback mount, or copying stuff to a removable harddrive, perhaps I don't really care if data gets corrupted if the power drops while I am writing, as I can recreate the data. I'm always going to have that issue even with FAT32 and other dinosaurs (ext2). I *do*, however, care if unmount() doesn't write all the data, especially as "sync; sync; sync" doesn't appear to write the data either. -- Alex Bligh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/