Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757191Ab1EXDjY (ORCPT ); Mon, 23 May 2011 23:39:24 -0400 Received: from eu1sys200aog109.obsmtp.com ([207.126.144.127]:36625 "EHLO eu1sys200aog109.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756757Ab1EXDjX (ORCPT ); Mon, 23 May 2011 23:39:23 -0400 Message-ID: <4DDB284A.6040603@st.com> Date: Tue, 24 May 2011 09:08:50 +0530 From: viresh kumar User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: Randy Dunlap Cc: Stephen Rothwell , "linux-ide@vger.kernel.org" , Jeff Garzik , "linux-next@vger.kernel.org" , LKML Subject: Re: [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES References: <20110520165507.cba539d5.sfr@canb.auug.org.au> <20110522173227.5ba18817.randy.dunlap@oracle.com> <4DD9D5EB.3060807@st.com> <4DDA89A2.8010604@oracle.com> In-Reply-To: <4DDA89A2.8010604@oracle.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 25 On 05/23/2011 09:51 PM, Randy Dunlap wrote: >>> >> config PATA_ARASAN_CF >>> >> tristate "ARASAN CompactFlash PATA Controller Support" >>> >> + depends on DMADEVICES >>> >> select DMA_ENGINE >> > >> > Randy, >> > >> > I think we can also remove this "select DMA_ENGINE" line. > In that case, the newly added "depends on" line is not needed either, > since the "select DMA_ENGINE" is what causes the kconfig warning message. > Some sort of dependency must be present as PATA_ARASAN is using DMAENGINE routines and it will not compile unless DMA_ENGINE is enabled. So, depends on DMADEVICES will solve all these issues. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/