Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752261Ab1EXFIl (ORCPT ); Tue, 24 May 2011 01:08:41 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:61419 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926Ab1EXFIk (ORCPT ); Tue, 24 May 2011 01:08:40 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6355"; a="93185795" From: "Tanya Brokhman" To: "'Sebastian Andrzej Siewior'" , "'Mike Frysinger'" Cc: , , , , , "'open list'" References: <1306132882-9668-1-git-send-email-tlinder@codeaurora.org> <1306132882-9668-5-git-send-email-tlinder@codeaurora.org> <20110523123135.GA10785@linutronix.de> In-Reply-To: <20110523123135.GA10785@linutronix.de> Subject: RE: [PATCH v12 4/8] usb:gadget: Add SuperSpeed support to the Gadget Framework Date: Tue, 24 May 2011 08:10:23 +0300 Message-ID: <00eb01cc19d0$e526a9b0$af73fd10$@org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AcwZRVssFknSazKrSUqUkXrTKIcAbgAiwKRg Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 39 Hi Sebastian, > >+ case USB_REQ_GET_STATUS: > >+ if (!gadget_is_superspeed(gadget)) > >+ goto unknown; > >+ if (ctrl->bRequestType != (USB_DIR_IN | > USB_RECIP_INTERFACE)) > >+ goto unknown; > >+ value = 2; /* This is the length of the get_status reply > */ > >+ *((__le16 *)req->buf) = 0; > > Mike please correct me if I'm wrong bug this looks like a case for > put_unaligned_le16(). > Is someone actually using gadget support on blackfin? I'm asking > because > config_buf() (same file, upstream) is using req->buf to build the > descriptors in place and one element is le16 which should be affected. > Mike answered that you're right in your observation. I'm not familiar with blackfin. Could you please elaborate on this? I understand that I need to use put_unaligned_le16(), will do, but I would like to better understand why and if there is a way to test this so that blackfin won't be broken. Best regards, Tanya Brokhman Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/