Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756545Ab1EXNdR (ORCPT ); Tue, 24 May 2011 09:33:17 -0400 Received: from exht1.emulex.com ([138.239.113.183]:21669 "EHLO exht1.ad.emulex.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756447Ab1EXNdQ (ORCPT ); Tue, 24 May 2011 09:33:16 -0400 Date: Tue, 24 May 2011 09:32:47 -0400 From: James Smart User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: Stephen Boyd CC: "James E.J. Bottomley" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "Iannicelli, Alex" Subject: Re: [PATCH 3/9] [SCSI] lpfc: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning References: <1305244212-19183-1-git-send-email-sboyd@codeaurora.org> <1305244212-19183-4-git-send-email-sboyd@codeaurora.org> In-Reply-To: <1305244212-19183-4-git-send-email-sboyd@codeaurora.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Message-ID: <5b0f759a-66ec-4f31-bcdf-084e3a6aa4c3@exht1.ad.emulex.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1757 Lines: 51 Acked-by: James Smart Thanks -- james On 5/12/2011 7:50 PM, Stephen Boyd wrote: > Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following > warning: > > In file included from arch/x86/include/asm/uaccess.h:573, > from include/linux/uaccess.h:5, > from include/linux/highmem.h:7, > from include/linux/pagemap.h:10, > from include/linux/blkdev.h:12, > from drivers/scsi/lpfc/lpfc_debugfs.c:21: > In function 'copy_from_user': > arch/x86/include/asm/uaccess_64.h:65: > warning: call to 'copy_from_user_overflow' declared with > attribute warning: copy_from_user() buffer size is not provably > correct > > presumably due to buf_size being signed causing GCC to fail to > see that buf_size can't become negative. > > Cc: James Smart > Signed-off-by: Stephen Boyd > --- > drivers/scsi/lpfc/lpfc_debugfs.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c > index 3d96774..0af53a6 100644 > --- a/drivers/scsi/lpfc/lpfc_debugfs.c > +++ b/drivers/scsi/lpfc/lpfc_debugfs.c > @@ -1305,7 +1305,8 @@ static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes, > { > char mybuf[64]; > char *pbuf, *step_str; > - int bsize, i; > + int i; > + size_t bsize; > > /* Protect copy from user */ > if (!access_ok(VERIFY_READ, buf, nbytes)) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/