Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755313Ab1EXPhO (ORCPT ); Tue, 24 May 2011 11:37:14 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:43050 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753413Ab1EXPhM (ORCPT ); Tue, 24 May 2011 11:37:12 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=CDc7KJNgOkB8fkUiceSbDRZwSwsbYV+UpsKNoSHYqYoaujd3aMm4KVdPDdyE3wv/nP 0x/gCEIuZ6fVNqhOZJ+wNjiRspQ1w3LfrQDxiK7xCo0X0ioHqmGFK0LAaHaX6Hwy0A5M 4GBC85A/iCaZW2468XzNNi/8C8GTzCZyCo0AU= MIME-Version: 1.0 In-Reply-To: <20110524151910.GA23496@elte.hu> References: <20110524151910.GA23496@elte.hu> Date: Tue, 24 May 2011 18:37:11 +0300 X-Google-Sender-Auth: UFW_X1wJUhpgSf-tTOK6JU3BFeM Message-ID: Subject: Re: [PATCH v5] x86: UV uv_tlb.c cleanup From: Pekka Enberg To: Ingo Molnar Cc: Cliff Wickman , linux-kernel@vger.kernel.org, Thomas Gleixner , "H. Peter Anvin" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 17 On Tue, May 24, 2011 at 6:19 PM, Ingo Molnar wrote: > Don't the kfree()s get changed - i.e. the patch has a side-effect? > > And yes, while this might be a kmem leak fix, it is a fix and a *SIDE EFFECT* > which i explicitly asked to be queued in a separate patch(es) from the large > cleanup patch ... > > The cleanup patch should be a cleanup of existing code - even if that code has > bugs. Nothing more. Bug fixes are for different patches. There's also renames in the patch that make it pretty hard to review for correctness. Formatting changes are best done as separate patches. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/