Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932190Ab1EXRcn (ORCPT ); Tue, 24 May 2011 13:32:43 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:43564 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756543Ab1EXRcm (ORCPT ); Tue, 24 May 2011 13:32:42 -0400 Date: Tue, 24 May 2011 13:28:25 -0400 (EDT) Message-Id: <20110524.132825.968974982805294440.davem@davemloft.net> To: vfalico@redhat.com Cc: dlstevens@us.ibm.com, jmorris@namei.org, kaber@trash.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, mmarek@suse.cz, netdev@vger.kernel.org, netdev-owner@vger.kernel.org, pekkas@netcore.fi, yoshfuji@linux-ipv6.org Subject: Re: [PATCH v4 1/1] igmp: call ip_mc_clear_src() only when we have no users of ip_mc_list From: David Miller In-Reply-To: <20110524091505.GA21550@darkmag.usersys.redhat.com> References: <20110520162709.GA3497@darkmag.usersys.redhat.com> <20110524091505.GA21550@darkmag.usersys.redhat.com> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Tue, 24 May 2011 10:28:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 22 From: Veaceslav Falico Date: Tue, 24 May 2011 11:15:05 +0200 > In igmp_group_dropped() we call ip_mc_clear_src(), which resets the number > of source filters per mulitcast. However, igmp_group_dropped() is also > called on NETDEV_DOWN, NETDEV_PRE_TYPE_CHANGE and NETDEV_UNREGISTER, which > means that the group might get added back on NETDEV_UP, NETDEV_REGISTER and > NETDEV_POST_TYPE_CHANGE respectively, leaving us with broken source > filters. > > To fix that, we must clear the source filters only when there are no users > in the ip_mc_list, i.e. in ip_mc_dec_group() and on device destroy. > > Acked-by: David L Stevens > Signed-off-by: Veaceslav Falico Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/