Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757187Ab1EXR7m (ORCPT ); Tue, 24 May 2011 13:59:42 -0400 Received: from mail-gw0-f46.google.com ([74.125.83.46]:49164 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753777Ab1EXR7k (ORCPT ); Tue, 24 May 2011 13:59:40 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=oXkRfVEGtr9tGcm86ntkhXEiQU0xQraQXu+QVoiW32Nl1i3reFzUtSE0TXeLiLbqm7 3TTqF2mt/NUKl5UdgxtyBTXPg1ItLotzkvqm2DTkVQJTShrENIVtwVVdhmaQkIrXVYDB KDAlaPOjiuYpdAGPrgwxYcP2WKXUrCaXT0H7Q= MIME-Version: 1.0 In-Reply-To: <1306258716.7501.35.camel@hiromu-MacBook> References: <1306167401.18840.8.camel@hiromu-MacBook> <1306242400.7501.10.camel@hiromu-MacBook> <4DDBB150.2090602@suse.cz> <1306247192.7501.25.camel@hiromu-MacBook> <4DDBC846.8050402@suse.cz> <1306258716.7501.35.camel@hiromu-MacBook> Date: Tue, 24 May 2011 13:59:39 -0400 Message-ID: Subject: Re: [PATCH] Kconfig: add warning about permission of config file From: Arnaud Lacombe To: Hiromu Yakura Cc: Michal Marek , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, zippel@linux-m68k.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1432 Lines: 36 Hi, On Tue, May 24, 2011 at 1:38 PM, Hiromu Yakura wrote: > On Tue, May 24, 2011, at 0:50, Arnaud Lacombe > wrote: >> On Tue, May 24, 2011 at 11:01 AM, Michal Marek wrote: >> > I see, qconf lacks a check for the return value of conf_write() in >> > ConfigMainWindow::closeEvent(), gconf does check the return value, but only >> > displays it in the bottom box of the main window instead of a message box. >> > Neither of them return failure in the error case. These bugs should be >> > indeed fixed. >> > >> agree. >> >> > But I don't like the directory permission check, it only >> > handles one case, but does not handle permission on the .config file itself >> > with KCONFIG_OVERWRITECONFIG=1, ENOSPC and so on. >> > >> seconded. > I'm sorry for forgetting to handle a case which was set KCONFIG_OVERWRITECONFIG. > So I rewrote the patch and attach it. > > Thanks for your advice. > > Signed-off-by: Hiromu Yakura > Let me re-state: your patch does not handle all the case where conf_write() may fails, and I do not think we want to preemptively check for all errors open(2) may return. - Arnaud -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/