Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933618Ab1EXVwK (ORCPT ); Tue, 24 May 2011 17:52:10 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:55339 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753770Ab1EXVwI convert rfc822-to-8bit (ORCPT ); Tue, 24 May 2011 17:52:08 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=oKoos/GVGkWp/BO6RP6vPlYpLTbchdDGR+sOTMDcs+LLz/sQlEp1cmfxzMeShflBCU a40nY3qRcwNlsHqlhpsRFdJDNCAs6VXNp4ctVYrcAsYLGdRh+8DT/EeshpnS1UWAqGhN kWxN8eylQbYA1neEzktkJr/ppC17tNJTU8VoA= MIME-Version: 1.0 In-Reply-To: <20110516092429.GC26487@linutronix.de> References: <1304166750-31125-1-git-send-email-dsd@laptop.org> <1304166750-31125-12-git-send-email-dsd@laptop.org> <20110516092429.GC26487@linutronix.de> Date: Tue, 24 May 2011 22:52:07 +0100 X-Google-Sender-Auth: _h_b1tpYo_tVUehi06MumWIReDk Message-ID: Subject: Re: [PATCH 11/11] x86, olpc: Add XO-1.5 SCI driver From: Daniel Drake To: Sebastian Andrzej Siewior , linux-acpi@vger.kernel.org Cc: x86@kernel.org, linux-kernel@vger.kernel.org, dilinger@queued.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1111 Lines: 29 On 16 May 2011 10:24, Sebastian Andrzej Siewior wrote: > * Daniel Drake | 2011-04-30 13:32:30 [+0100]: > >>+static DECLARE_WORK(sci_work, process_sci_queue_work); >>+ >>+static u32 xo15_sci_gpe_handler(acpi_handle gpe_device, u32 gpe, void *context) >>+{ >>+ ? ? ?schedule_work(&sci_work); >>+ ? ? ?return ACPI_INTERRUPT_HANDLED | ACPI_REENABLE_GPE; >>+} > > I know this is too much to ask but acpi_install_gpe_handler() looks like > a custom irq demultiplexor which lacks the support for threaded irqs. Thanks for looking at the patch. I guess you mean that ACPI should hide all this behind an irq_chip abstraction. I had a quick look at doing this but not being very familiar with ACPI nor irq_chip I don't think I'm the right person for the task. Hopefully it is not seen as a merge requirement... CCing ACPI list for comments. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/