Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752148Ab1EYIxW (ORCPT ); Wed, 25 May 2011 04:53:22 -0400 Received: from mga02.intel.com ([134.134.136.20]:36354 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180Ab1EYIxV (ORCPT ); Wed, 25 May 2011 04:53:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,266,1304319600"; d="scan'208";a="4449797" Subject: Re: [PATCH 1/5] dmaengine: add ep93xx DMA support From: "Koul, Vinod" To: Linus Walleij Cc: Mika Westerberg , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hsweeten@visionengravers.com, ryan@bluewatersys.com, Dan Williams , Grant Likely In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Wed, 25 May 2011 13:49:53 +0530 Message-ID: <1306311593.30236.103.camel@vkoul-udesk3> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1194 Lines: 27 On Wed, 2011-05-25 at 10:39 +0200, Linus Walleij wrote: > 2011/5/22 Mika Westerberg : > > > The ep93xx DMA controller has 10 independent memory to peripheral (M2P) > > channels, and 2 dedicated memory to memory (M2M) channels. M2M channels can > > also be used by SPI and IDE to perform DMA transfers to/from their memory > > mapped FIFOs. > > No so much a review comment as an observation: I opposed the merge of the > EP93xx SPI driver in drivers/spi/ep93xx_spi.c on the grounds that it was close > enough to amba-pl022.c that it could use that driver instead. > > One of the arguments against was that you were going to do custom DMA > and stuff. Now you're using the DMAengine, so can you please reconsider > refactoring amba-pl022.c to suit your needs and you'll get DMA support for > free mor or less. Linus is the dma IP same as existing ones? In that case we shouldn't have a new driver for same IP. -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/