Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933192Ab1EYIjz (ORCPT ); Wed, 25 May 2011 04:39:55 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:36740 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932782Ab1EYIjx (ORCPT ); Wed, 25 May 2011 04:39:53 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=VKlyLhU4NgsFMB7AOLxgk9LlFUlS/Shvq/wifDk4ghrkNOjLOvUiOL0ODAzNLZP5XP FiCpRYzsfTVDK642EHdQkfupAXWK+RtPp93X3omhKiNQ0o3tDMNMdV+DIfswdGHrBqKj 5DiKl/Ax/HFq2IjPZ4BA7y2CUH90nBqqMF8aA= MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 25 May 2011 10:39:52 +0200 X-Google-Sender-Auth: rvPZQt6VKK6IjSbcDGuMsiPC5iw Message-ID: Subject: Re: [PATCH 1/5] dmaengine: add ep93xx DMA support From: Linus Walleij To: Mika Westerberg Cc: linux-arm-kernel@lists.infradead.org, Vinod Koul , linux-kernel@vger.kernel.org, hsweeten@visionengravers.com, ryan@bluewatersys.com, Dan Williams , Grant Likely Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1016 Lines: 23 2011/5/22 Mika Westerberg : > The ep93xx DMA controller has 10 independent memory to peripheral (M2P) > channels, and 2 dedicated memory to memory (M2M) channels. M2M channels can > also be used by SPI and IDE to perform DMA transfers to/from their memory > mapped FIFOs. No so much a review comment as an observation: I opposed the merge of the EP93xx SPI driver in drivers/spi/ep93xx_spi.c on the grounds that it was close enough to amba-pl022.c that it could use that driver instead. One of the arguments against was that you were going to do custom DMA and stuff. Now you're using the DMAengine, so can you please reconsider refactoring amba-pl022.c to suit your needs and you'll get DMA support for free mor or less. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/