Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753120Ab1EYJJa (ORCPT ); Wed, 25 May 2011 05:09:30 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:48900 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689Ab1EYJJ1 (ORCPT ); Wed, 25 May 2011 05:09:27 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=epfVaIdCVKgi4FWg4AJ4Bil/F4R+XLFITXDJc9CSoRPlkMQ9cSGEIu8Wey8OBKC1m2 JqAIeqR8ULHYMMIuLyAbfJ4qbewMvmJdx0zFmaJDZjxUAqOAS76Q0ugJchWLvDf1UcJk IjgbfEZiDPDiHW++QfVHneVbgcLCy8VtFTkmc= MIME-Version: 1.0 In-Reply-To: <1306311593.30236.103.camel@vkoul-udesk3> References: <1306311593.30236.103.camel@vkoul-udesk3> Date: Wed, 25 May 2011 11:09:26 +0200 X-Google-Sender-Auth: PkcuHmsG9_OxfCnWdYd6ajLRZ6c Message-ID: Subject: Re: [PATCH 1/5] dmaengine: add ep93xx DMA support From: Linus Walleij To: "Koul, Vinod" Cc: Mika Westerberg , linux-kernel@vger.kernel.org, Grant Likely , hsweeten@visionengravers.com, ryan@bluewatersys.com, Dan Williams , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 32 2011/5/25 Koul, Vinod : > On Wed, 2011-05-25 at 10:39 +0200, Linus Walleij wrote: >> 2011/5/22 Mika Westerberg : >> >> > The ep93xx DMA controller has 10 independent memory to peripheral (M2P) >> > channels, and 2 dedicated memory to memory (M2M) channels. M2M channels can >> > also be used by SPI and IDE to perform DMA transfers to/from their memory >> > mapped FIFOs. >> >> No so much a review comment as an observation: I opposed the merge of the >> EP93xx SPI driver in drivers/spi/ep93xx_spi.c on the grounds that it was close >> enough to amba-pl022.c that it could use that driver instead. >> >> One of the arguments against was that you were going to do custom DMA >> and stuff. Now you're using the DMAengine, so can you please reconsider >> refactoring amba-pl022.c to suit your needs and you'll get DMA support for >> free mor or less. > > Linus is the dma IP same as existing ones? > In that case we shouldn't have a new driver for same IP. Nope, not as far as I can tell. The fear of this IP being an amba-pl08x.c already hit med so I checked the register map, but it appears to be unique. I haven't compared it to amba-pl330.c though. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/