Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757028Ab1EYMyI (ORCPT ); Wed, 25 May 2011 08:54:08 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:38586 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753456Ab1EYMyH convert rfc822-to-8bit (ORCPT ); Wed, 25 May 2011 08:54:07 -0400 MIME-Version: 1.0 In-Reply-To: References: <1306323570-11133-1-git-send-email-vinod.koul@intel.com> <1306323570-11133-3-git-send-email-vinod.koul@intel.com> Date: Wed, 25 May 2011 14:54:06 +0200 Message-ID: Subject: Re: [PATCH 2/2] dmaengine: add TODO items for future work on dma drivers From: Per Forlin To: "Koul, Vinod" Cc: LKML , linux-arm-kernel@lists.infradead.org, Russell King , Linus Walleij , Dan Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1631 Lines: 44 On 25 May 2011 14:39, Per Forlin wrote: > On 25 May 2011 13:39, Koul, Vinod wrote: >> From: Vinod Koul >> >> Signed-off-by: Vinod Koul >> --- >> ?drivers/dma/TODO | ? 12 ++++++++++++ >> ?1 files changed, 12 insertions(+), 0 deletions(-) >> ?create mode 100644 drivers/dma/TODO >> >> diff --git a/drivers/dma/TODO b/drivers/dma/TODO >> new file mode 100644 >> index 0000000..b67d184 >> --- /dev/null >> +++ b/drivers/dma/TODO >> @@ -0,0 +1,12 @@ >> +TODO for slave dma >> + >> +1. Move remaining drivers to use new slave interface >> +2. Remove old slave pointer machansim >> +3. Make issue_pending to start the transaction in below drivers >> + ? ? ? - mpc512x_dma >> + ? ? ? - imx-dma >> + ? ? ? - imx-sdma >> + ? ? ? - mxs-dma.c >> + ? ? ? - dw_dmac >> + ? ? ? - intel_mid_dma >> + ? ? ? - ste_dma40 > ste_dma40 already does this. At least is does so in 2.6.39. I may not > be up to date of what is merged for 2.6.40. > I looked at the code once more and ste_dam40 should be on this list :) ste_dm40 only treats issue_pending accordingly if the DMA driver is in idle. If the dma is active the desc:s submitted from submit() will be started later on from dma-irq-function. The dma-irq-function simply checks if there are pending desc are start them if any. I will fix a patch for this. /Per -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/