Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757974Ab1EYOko (ORCPT ); Wed, 25 May 2011 10:40:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29376 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757948Ab1EYOkm (ORCPT ); Wed, 25 May 2011 10:40:42 -0400 Date: Wed, 25 May 2011 10:40:37 -0400 From: Andy Gospodarek To: Weiping Pan Cc: jpirko@redhat.com, Jay Vosburgh , Andy Gospodarek , "open list:BONDING DRIVER" , open list Subject: Re: [PATCH] bonding:update xmit_hash_policy description Message-ID: <20110525144036.GJ21309@gospo.rdu.redhat.com> References: <1306317904-18740-1-git-send-email-panweiping3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1306317904-18740-1-git-send-email-panweiping3@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1577 Lines: 33 On Wed, May 25, 2011 at 06:05:04PM +0800, Weiping Pan wrote: > xmit_hash_policy supports layer2+3 now, > and both balance-xor and 802.3ad use xmit_hash_policy. > > Signed-off-by: Weiping Pan > --- > drivers/net/bonding/bond_main.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index 088fd84..d1f5606 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -147,8 +147,7 @@ MODULE_PARM_DESC(lacp_rate, "LACPDU tx rate to request from 802.3ad partner " > module_param(ad_select, charp, 0); > MODULE_PARM_DESC(ad_select, "803.ad aggregation selection logic: stable (0, default), bandwidth (1), count (2)"); > module_param(xmit_hash_policy, charp, 0); > -MODULE_PARM_DESC(xmit_hash_policy, "XOR hashing method: 0 for layer 2 (default)" > - ", 1 for layer 3+4"); > +MODULE_PARM_DESC(xmit_hash_policy, "balance-xor and 802.3ad hashing method: 0 for layer 2 (default), 1 for layer 3+4, 2 for layer 2+3"); This is a good idea and a definite bug-fix. Thanks for posting it. I do not want to create a description that is longer than 80 characters in the source if I can help it. I went ahead and cleaned up all the descriptions and have posted a followup patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/