Date: Wed, 25 May 2011 11:29:53 -0500 (CDT)
From: Christoph Lameter <cl@linux.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
cc: James Morris <jmorris@namei.org>, Pekka Enberg <penberg@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: SLUB regression in current Linus
In-Reply-To: <1306338149.2820.27.camel@edumazet-laptop>
Message-ID: <alpine.DEB.2.00.1105251129300.26118@router.home>
References: <alpine.LRH.2.00.1105242146240.12134@tundra.namei.org>  <alpine.LRH.2.00.1105242204100.12283@tundra.namei.org>  <alpine.DEB.2.00.1105240908100.25760@router.home>  <alpine.LRH.2.00.1105250813290.16922@tundra.namei.org>  <alpine.DEB.2.00.1105250945240.23309@router.home>
 <1306338149.2820.27.camel@edumazet-laptop>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 703
Lines: 19

On Wed, 25 May 2011, Eric Dumazet wrote:

> > Index: linux-2.6/mm/slub.c
> > ===================================================================
> > --- linux-2.6.orig/mm/slub.c	2011-05-25 09:41:27.000000000 -0500
> > +++ linux-2.6/mm/slub.c	2011-05-25 09:41:39.000000000 -0500
> > @@ -1884,7 +1884,8 @@ debug:
> >  	deactivate_slab(s, c);
> >  	c->page = NULL;
>
> is this c->page = NULL; really necessary ?

No. deactivate_slab() already sets it to NULL.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/