Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173Ab1EYUEe (ORCPT ); Wed, 25 May 2011 16:04:34 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:34119 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900Ab1EYUEc convert rfc822-to-8bit (ORCPT ); Wed, 25 May 2011 16:04:32 -0400 MIME-Version: 1.0 In-Reply-To: References: <4DDB8BF6.2000304@fusionio.com> <4DDCB1C8.7040708@fusionio.com> <4DDD5240.2060308@fusionio.com> <4DDD55D6.1080909@fusionio.com> From: Linus Torvalds Date: Wed, 25 May 2011 13:03:38 -0700 Message-ID: Subject: Re: [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS] To: Parag Warudkar Cc: Jens Axboe , "linux-kernel@vger.kernel.org" , "James.Bottomley@hansenpartnership.com" , "akpm@linux-foundation.org" , Linux SCSI List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 22 On Wed, May 25, 2011 at 12:52 PM, Parag Warudkar wrote: > > +static inline int sdev_early_check(struct scsi_device *sdev) > +{ > + ? ? ? if (!sdev || sdev->sdev_state == SDEV_DEL > + ? ? ? ? ? ? ? || sdev->sdev_state > SDEV_QUIESCE) > + ? ? ? ? ? ? ? return -ENXIO; > + ? ? ? return 0; > +} Can somebody explain why it's those states, and nothing else? Quite frankly, if it's about "don't oops on sdev->queue not existing", then test for that. Not for some random and uncommented list of states. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/