Date: Wed, 25 May 2011 13:40:51 -0700
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Vivek Goyal <vgoyal@redhat.com>, Jens Axboe <jaxboe@fusionio.com>,
        linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: Mysterious CFQ crash and RCU
Message-ID: <20110525204051.GI2341@linux.vnet.ibm.com>
Reply-To: paulmck@linux.vnet.ibm.com
References: <20110519222404.GG12600@redhat.com>
 <20110521210013.GJ2271@linux.vnet.ibm.com>
 <20110523152141.GB4019@redhat.com>
 <20110523153848.GC2310@linux.vnet.ibm.com>
 <1306318636.9059.33.camel@t41.thuisdomein>
 <20110525153327.GA2341@linux.vnet.ibm.com>
 <1306345492.21978.15.camel@t41.thuisdomein>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1306345492.21978.15.camel@t41.thuisdomein>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1550
Lines: 37

On Wed, May 25, 2011 at 07:44:51PM +0200, Paul Bolle wrote:
> On Wed, 2011-05-25 at 08:33 -0700, Paul E. McKenney wrote:
> > On Wed, May 25, 2011 at 12:17:16PM +0200, Paul Bolle wrote:
> > > 2) So shouldn't either the config entry be set to "tristate" or the
> > > module support removed from kernel/rcutree_trace.c?
> > 
> > No.
> > 
> > Just set CONFIG_RCU_TRACE=y and you will have RCU tracing.  Here is why:
> > 
> >[...]
> >
> > So you can set CONFIG_RCU_TRACE, and if you are running CONFIG_SMP=y,
> > you will have RCU tracing in your kernel.
> 
> The point - which I must have expressed poorly - is that there's a
> mismatch between the code in kernel/rcutree_trace.c (which allows for
> that file to be built as a module) and its kconfig setup (which requires
> it to be either builtin or not built at all, since it's boolean).
> Anyhow, your explanation makes clear that this kconfig setup is actually
> correct and that the module support in kernel/rcutree_trace.c might as
> well be removed, since that file can never be part of a module.

Ah -- this is using (perhaps abusing) the module capabilities to
get initialization and cleanup done.

Interesting point, though -- might be worth allowing this to be built
as a module.

Regardless, apologies for missing your point.

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/